@OXINARF wrote:
Right now we have 45 labels in GitHub and sometimes I find difficult to choose which ones to use. I would say other people also find it hard because many times we have issues and PRs without any label. Some labels are long and there's inconsistencies in the way they are written. We try to have meaningful titles, labels should only be a fast way to identify an issue/PR.
For these reasons I would like to simplify our list of labels. I'll list the current labels and any suggestion I have on what to do with them:
- 3DR Solo requirement - change to Solo, I think it's clear enough
- AllVehicles - this seems to be used when there are changes to/affects multiple vehicles or when there are changes to libraries. I propose we add a new Library label to more explicitly show changes to libraries
- AntennaTracker
- APM - I think this was intended to be used for the old APM boards, but it is confused with ArduPilot. I'm not sure of a clearer name, would AVR be correct?
- Bebop - we have Linux, I don't think there's a need for a label for each board
- BUG
- Camera/Gimbal - put it under the new Library or if someone really wants it change to Mount
- Cleanup - I don't see a need for this (it was used 4 times), either the title or the message of the issue/PR should be clear on that
- Copter
- DataFlash - put it under the new Library label
- Dev Environment - change to DevEnv
- Documentation - change to Docs
- Duplicate
- Efficiency Improvement - we already have Enhancement, I don't see a need for a different label
- EKF(where is my t-shirt) - I know that the t-shirt is an old joke, do we still want it in the label? Also the only reason I'm not proposing to join this one to the Library one is that EKF is big central point for us
- Enhancement
- Flight Behavior - I understand the label, but this should be clear from the issue/PR text, not in a label. If someone really wants the label it should be changed to FlightBehavior
- GPS - put it under the new Library label
- in progress - change to WIP, change color to be more prominent (I accept suggestions for that)
- invalid - only used twice, but it can be useful to label issues that are verified to be incorrect. Change to Invalid
- Linux
- Log Analyser - change to Tools so it is more generic
- Navio - remove, Linux should be enough
- Need-rework, change to NeedRework
- Non-functional change - once again, this should be clear from issue/PR text, no need for the label. Also I've seen before someone thinking it was a non-functional change but someone else finds it was
- OldIssuesList - no use for it, remove
- Optimisation - we have Enhancement, should be enough
- Plane
- Planner - issues/PR with Mission Planner should be in its own GitHub, if any is opened in ArduPilot just label it Invalid
- PX4
- QuadPlane
- Question - questions don't belong to GitHub, but this sometimes seems to be used when an answer is needed, so change to NeedAnswer. Regarding this, I would like to propose that any issue/PR tagged with this and that doesn't have an answer in 3 months to be closed
- raspilot - Linux is enough, remove
- Ready - we have Reviewed, which I find a better name, remove this one
- Requires GCS change - change to ChangeToGCS
- Reviewed
- Rover
- Safety Feature - change to Safety, it can be a feature or a safety issue we have in current code
- Simulator - change to SITL
- size-small, I don't see that any issue/PR tagged with this is handled faster so I propose to remove. If someone wants it, change to SmallChange
- Support - this may seem equal to Invalid but this one is for issues that should be in the forum, not an issue that was verified to be incorrect
- TradHeli
- Usability improvement - use Enhancement instead
- waf - change to BuildSystem
- wontfix - change to NotAccepted, won't fix looks like we have a bug that we don't want to fix
We still end up with 30 labels (worst case 33) but I think it's better than what we currently have.
Another problem is the milestones:
- there are milestones opened for already released versions (Plane 3.5.1 and 3.5.2, Copter 3.3.0). I propose to close these ones, reassigning any open issue/PR to the next release version
- there are two milestones called Next Major Release and Next Next Major Release which don't make much sense to me and also have 0 issues/PRs assigned to them. I propose removal of these
- there's a AC with Tablet only that doesn't seem to have any work done, doesn't have a due date, etc. I would like to remove it because it seems it's only used to group some issues
Looking forward for your input, thanks.
Posts: 5
Participants: 3